fix: match .tsx and .mjs/.cjs in two extension checks that omit them - #1742
Open
elhoim wants to merge 2 commits into
Open
fix: match .tsx and .mjs/.cjs in two extension checks that omit them#1742elhoim wants to merge 2 commits into
elhoim wants to merge 2 commits into
Conversation
This is the relevance gate that decides whether the Stop-hook cross-reference check runs at all. It accepted .ts but not .tsx, so editing any of the 24 .tsx files under skills/ (skills/Telos/DashboardTemplate) skipped the pass entirely — a silent no-run rather than a clean result. Both scope checks are updated so the ~/.claude and LIFEOS branches stay in step.
detectTestCommand matched .js only, so an ESM or CommonJS test file fell through to the 'bun test' default — silently running under a different runner than the explicit .js branch intends. .tsx is deliberately left alone: it also falls to the default, but 'bun test' is the correct command for it, so listing it would change nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits, one per fix, so each can be cherry-picked independently.
a1836dd67031e7Two extension checks that omit a sibling type that actually exists in the tree. Same shape as #1741, different extensions.
a1836dd—hooks/handlers/DocCrossRefIntegrity.ts:196,210. This is the relevance gate deciding whether the Stop-hook cross-reference check runs at all. It accepted.tsbut not.tsx, so editing any of the 24.tsxfiles underskills/(all inskills/Telos/DashboardTemplate) skipped the pass entirely. The failure mode is a silent no-run that is indistinguishable from a clean result. Both scope checks are updated together so the~/.claudeandLIFEOSbranches stay in step.67031e7—skills/Evals/Graders/CodeBased/BinaryTests.ts:70.detectTestCommandmatched.jsonly, so.mjsand.cjsfell through to thebun testdefault and ran under a different runner than the explicit.jsbranch intends.One thing deliberately not changed.
.tsxalso falls throughdetectTestCommandto the default, butbun testis the right command for it, so adding it would change nothing. Listing it would have made the diff look more thorough while doing nothing, which is worse than leaving it.Two sites checked and left alone, noted so the omission reads as deliberate:
hooks/handlers/RebuildArchSummary.ts:59omits.tsx, but its five tracked directories (hooks,ALGORITHM,TOOLS,USER/CONFIG,USER/SECURITY) contain zero.tsxfiles. It is correctly scoped, not deficient..mdvs.markdownis handled inPULSE/lib/provenance-watcher.ts:35, and there are no.markdownfiles anywhere in the repo, so nothing is missing there either.Testing. Both files transpile clean under
bun build --no-bundle. These are branch-condition changes in a relevance gate and a command selector, so the meaningful check is the extension census behind them:git ls-filesreports 122.tsxin the payload (24 underskills/), 5.mjs, and 0.markdown.