Skip to content

fix(hooks): reject non-ASCII lead-in text in SatisfactionCapture rating guards #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takanorinishida wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(hooks): reject non-ASCII lead-in text in SatisfactionCapture rating guards #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions LifeOS/install/hooks/SatisfactionCapture.hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ function parseExplicitRating(prompt: string): { rating: number; comment?: string
if (fractionMatch) {
const fRating = parseInt(fractionMatch[1], 10);
const fRest = fractionMatch[2].replace(/^[\s!.,:;-]+/, '').trim() || undefined;
if (fRest && SENTENCE_STARTERS.test(fRest)) return null; // "2/10 items" is not a rating
// "2/10 items" is not a rating; neither is "2/10件" — a non-ASCII lead-in
// means fRest is describing something, not commenting on the score (#i18n).
if (fRest && (SENTENCE_STARTERS.test(fRest) || /^[^\x00-\x7F]/.test(fRest))) return null;
return { rating: fRating, comment: fRest };
}

Expand All @@ -141,7 +143,11 @@ function parseExplicitRating(prompt: string): { rating: number; comment?: string
if (rating < 1 || rating > 10) return null;

const afterNumber = trimmed.slice(match[1].length);
if (afterNumber.length > 0 && /^[/.\dA-Za-z]/.test(afterNumber)) return null;
// Reject a leading digit followed immediately by non-ASCII text (e.g. Japanese
// "2はあとで" — "item 2, later" — is not a rating of 2). The ASCII classes below
// this guarded against before; non-ASCII text right after the digit is the same
// "describing something, not rating it" shape (#i18n).
if (afterNumber.length > 0 && /^[/.\dA-Za-z]|^[^\x00-\x7F]/.test(afterNumber)) return null;

if (rest && SENTENCE_STARTERS.test(rest)) return null;

Expand Down