Repository navigation
Fix: All in the Log filter does nothing - #134
Merged
Merged
Conversation
Radix ToggleGroup reports a deselect as '', so Segmented dropped every change to an empty value. The Log's All option is '', which left the filter stuck on Running or Failed. Segmented now prefixes values for Radix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking All in the Log's All | Running | Failed switch did nothing once Running or Failed was chosen.
Cause: Radix ToggleGroup reports a deselect as
'', andSegmentedignores''. The Log's All option has the value'', so its click was dropped too.Segmentednow hands Radix prefixed values, so an empty option value is selectable and a click on the selected option still keeps it.Test:
segmented.test.tsxcovers both cases (fails without the fix). Checked in the dev UI against the running daemon.🤖 Generated with Claude Code