Skip to content

Fix Linux/macOS build failures caused by removal of CoopVec ops (PR #8291) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damyanp merged 2 commits into from
Mar 26, 2026
Merged

Fix Linux/macOS build failures caused by removal of CoopVec ops (PR #8291) #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25f5019
Add LinalgMatrixLayout to DxilConstants.h
damyanp Mar 26, 2026
3547cb0
Remove unused static CheckLinalgInterpretation from DxilValidation.cpp
Copilot Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions include/dxc/DXIL/DxilConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,13 @@ enum class MatrixScope : uint32_t {
ThreadGroup = 2,
};

enum class LinalgMatrixLayout : uint32_t {
RowMajor = 0,
ColumnMajor = 1,
MulOptimal = 2,
OuterProductOptimal = 3,
};

// Must match D3D_INTERPOLATION_MODE
enum class InterpolationMode : uint8_t {
Undefined = 0,
Expand Down
22 changes: 0 additions & 22 deletions lib/DxilValidation/DxilValidation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,28 +974,6 @@ static void ValidateImmOperandForMathDxilOp(CallInst *CI, DXIL::OpCode Opcode,
}
}

static bool CheckLinalgInterpretation(uint32_t Input, bool InRegister) {
using CT = DXIL::ComponentType;
switch (static_cast<CT>(Input)) {
case CT::I16:
case CT::U16:
case CT::I32:
case CT::U32:
case CT::F16:
case CT::F32:
case CT::U8:
case CT::I8:
case CT::F8_E4M3:
case CT::F8_E5M2:
return true;
case CT::PackedS8x32:
case CT::PackedU8x32:
return InRegister;
default:
return false;
}
}

// Validate the type-defined mask compared to the store value mask which
// indicates which parts were defined returns true if caller should continue
// validation
Expand Down