Register DxilCounters.cpp with hctgen and regenerate

[Copilot]

lib/DXIL/DxilCounters.cpp contains <py> code tags driven by the DXIL instruction database, but was never registered with add_hlsl_hctgen(). As a result it was never regenerated when HLSL_COPY_GENERATED_SOURCES was set, causing it to silently drift out of sync as new opcodes were added.

Changes

• cmake/modules/HCT.cmake — add_hlsl_hctgen() now automatically derives the CMake target name as ${mode}_${extension} (e.g. DxilCounters_h, DxilCounters_cpp). This ensures target names are unique even when the same hctgen mode generates both a .h and a .cpp file, without requiring any caller-visible special-casing. The one existing external reference to a target by name (DxilIntrinsicTables) is updated to DxilIntrinsicTables_h in tools/clang/lib/Sema/CMakeLists.txt.

• lib/DXIL/CMakeLists.txt — Registers DxilCounters.cpp with the codegen pipeline:

  add_hlsl_hctgen(DxilCounters OUTPUT DxilCounters.cpp CODE_TAG)

• lib/DXIL/DxilCounters.cpp — Regenerated. Previously-missing opcodes now covered:

  Counter	Added opcodes
  barrier	BarrierByMemoryType, BarrierByMemoryHandle, BarrierByNodeRecordHandle
  floats	FDot
  ints / uints	VectorReduceAnd, VectorReduceOr
  tex_cmp	SampleCmpGrad, SampleCmpBias
  tex_load	RawBufferVectorLoad
  tex_store	RawBufferVectorStore

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

[damyanp]

@copilot what is special about DxilCounters.cpp that means it needs a special TARGET_NAME parameter? None of the ones below seem to need this.

[Copilot]

The first argument to add_hlsl_hctgen serves double duty: it's both the hctgen generation mode (passed directly to hctgen.py) and the CMake target name. DxilCounters is the only hctgen mode that generates two separate files — DxilCounters.h (in include/dxc/DXIL/CMakeLists.txt) and DxilCounters.cpp (in lib/DXIL/CMakeLists.txt). Since both calls must pass DxilCounters as the mode, but CMake target names must be unique, one of them needs a different target name.

I tried renaming the mode to DxilCountersH for the .h side, but that breaks hctgen.py which only accepts fixed mode names. TARGET_NAME is the minimal way to decouple the CMake target name from the hctgen mode.

[damyanp]

@copilot I'm convinced that this is truly a special case. Is the target name actually important and relied upon anywhere? If not, then how about the output file extension is always added to the target name?

[Copilot]

The target names were not relied upon by name externally, with one exception: DxilIntrinsicTables in tools/clang/lib/Sema/CMakeLists.txt.

Implemented your suggestion in ddcbecf: the TARGET_NAME parameter is removed and the target name is now always auto-derived as ${mode}_${extension} (e.g. DxilCounters_h, DxilCounters_cpp). Updated the one external reference accordingly (DxilIntrinsicTables → DxilIntrinsicTables_h).