Conversation
|
|
||
| INSERT INTO application.acl (role, action, resource) | ||
| VALUES | ||
| ('trn:temboard:core:group:mass/dba', '*', 'trn:temboard:core:instance:mass'), |
There was a problem hiding this comment.
| ('trn:temboard:core:group:mass/dba', '*', 'trn:temboard:core:instance:mass'), | |
| ('trn:temboard:core:group:mass/dba', '*', 'trn:temboard:core:instance:mass/*'), |
| return [TRN("*", "*", "*")] | ||
|
|
||
|
|
||
| def configure_authorization(role=None, action=None, resource=None): |
There was a problem hiding this comment.
Où est-ce utilisé ?
Je ne vois pas l'intérêt. Autant passer directement en paramètre à check_acl().
There was a problem hiding this comment.
Comme check() est ajouté au before_request de flask, il ne me semble pas possible de lui passer des param, j'ai donc créé un décorateur pour impacter le test d'authorization sur une route en particulier, ce n'est aps utilisé pour le moment. Je peux le supprimer mais en fait je peux également supprimer les parametres de check(). Pour le moment on utilise toujours anonymous ou g.current_user comme role et g.instance ou * pour la resource.
There was a problem hiding this comment.
j'ai supprimé le décorateur on verra si le besoin s'en fait sentir.
dde5737 to
dbf480c
Compare
02d3e4a to
81d386a
Compare
| assert str(parents[0]) == "*" | ||
| assert str(parents[1]) == "trn:temboard:core:user:alice" | ||
| assert str(parents[2]) == "trn:temboard:core:user:*" | ||
| assert str(parents[3]) == "trn:temboard:core:*:*" | ||
| assert str(parents[4]) == "trn:temboard:*:*:*" |
There was a problem hiding this comment.
I feels like the order of parents is reversed, starting from index 1.
This would look more natural:
assert str(parents[0]) == "*"
assert str(parents[4]) == "trn:temboard:*:*:*"
assert str(parents[3]) == "trn:temboard:core:*:*"
assert str(parents[2]) == "trn:temboard:core:user:*"
assert str(parents[1]) == "trn:temboard:core:user:alice"| groups=[g.name for g in self.groups if g.environment], | ||
| environments=[g.environment.name for g in self.groups if g.environment], |
There was a problem hiding this comment.
Is it related to current commit?
7bf2132 to
ea8ce84
Compare
Also remove anonymous_allowed, admin_required and apikey_allowed decorator
Also remove admin_required and anonymous_allowed decorator
3 participants
No description provided.