Skip to content

fix(settings): expose highlightsFirstEnabled in boot flags#3866

Merged
pnvasanth merged 2 commits into
mainfrom
fix/expose-highlights-first-in-boot
May 11, 2026
Merged

fix(settings): expose highlightsFirstEnabled in boot flags#3866
pnvasanth merged 2 commits into
mainfrom
fix/expose-highlights-first-in-boot

Conversation

@pnvasanth
Copy link
Copy Markdown
Contributor

Summary

transformSettingFlags in src/common/flags.ts whitelists which Settings.flags keys the boot endpoint sends back to the client. highlightsFirstEnabled was saved on write (mutation works fine, value persists in the JSONB column) but stripped on read — so the apps "Pin Happening Now to top" Switch always rendered as unchecked after a page refresh, even when the user had enabled it.

Fix is a one-line addition to the whitelist with a ?? false default, matching the opt-in pattern used by browsingContextEnabled.

Test plan

  • pnpm run lint clean
  • CI runs the Jest suite
  • Manual after deploy: toggle on in Feed Settings → reload → checkbox stays checked

transformSettingFlags whitelists which Settings.flags fields the boot
endpoint surfaces to the client. highlightsFirstEnabled was stored on
write but stripped on read, so the apps Switch always rendered as
unchecked after refresh.
@pnvasanth pnvasanth self-assigned this May 11, 2026
@pulumi
Copy link
Copy Markdown

pulumi Bot commented May 11, 2026

🍹 The Update (preview) for dailydotdev/api/prod (at 36961da) was successful.

✨ Neo Explanation

Routine deployment of build `4af397ce` adding a `highlightsFirstEnabled` user settings flag; all workloads receive the new image, and per-commit migration jobs are rotated as expected. ✅ Low Risk

This is a standard application deployment rolling out a new build (4af397ce) across all services. The code change adds a highlightsFirstEnabled feature flag (defaulting to false) to the user settings flag transformer. All deployments and cron jobs are updated solely to reflect the new image tag and version label.

New migration Jobs are created for the new commit (both DB and Clickhouse), and the previous migration Jobs from the prior commit are deleted — this is the normal migration lifecycle pattern for this stack.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-generic-referral-reminder-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-4af397ce                       kubernetes:batch/v1:Job        create
~   vpc-native-daily-digest-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
-   vpc-native-api-db-migration-0cb1002c                       kubernetes:batch/v1:Job        delete
~   vpc-native-personalized-digest-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-0cb1002c               kubernetes:batch/v1:Job        delete
~   vpc-native-clean-channel-highlights-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-daily-quests-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-opportunities-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-worker-job-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-squad-posts-analytics-refresh-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-digests-cron                            kubernetes:batch/v1:CronJob    update
+   vpc-native-api-clickhouse-migration-4af397ce               kubernetes:batch/v1:Job        create
~   vpc-native-update-tags-str-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-update-achievement-rarity-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-monthly-best-post-archives-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-updated-sync-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-channel-highlights-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                       kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                              kubernetes:apps/v1:Deployment  update
~   vpc-native-generate-search-invites-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                                      kubernetes:apps/v1:Deployment  update
~   vpc-native-materialize-yearly-best-post-archives-cron      kubernetes:batch/v1:CronJob    update
... and 11 other changes

@pnvasanth pnvasanth merged commit eef585e into main May 11, 2026
10 checks passed
@pnvasanth pnvasanth deleted the fix/expose-highlights-first-in-boot branch May 11, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant