chore: remove plus_api_landing_v2 flag#6057
Open
nimrodkra wants to merge 1 commit into
Open
Conversation
The plus_api_landing_v2 experiment won and rolled out to 100% of users. Remove the feature flag and hard-code the winning variation across all 11 consumer components so the control branch is no longer maintained. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
plus_api_landing_v2experiment won and rolled out to 100% of users. Remove the feature flag and hard-code the winning API-first variation across all 11 consumer components so we no longer maintain the losing branch.What changed
featurePlusApiLandingfrompackages/shared/src/lib/featureManagement.ts.Get API Access/API accessCTA copy andButtonColor.BaconinMainSection,UpgradeToPlus,PlusUserBadge,CustomFeedEmptyScreen,PlusMobileEntryBanner,PlusGrid.PlusInfo,PlusDesktop,PlusMobile,PlusFAQ) now always useplusInfoCopyApi,plusFeatureListApiFirst,plusFAQItemsApi, and render<PlusApiShowcase />.Out of scope
featurePlusCtaCopy(plus_cta_copy) is a separate, still-live flag and was intentionally left alone.defaultPlusInfoCopyControl,plusFeatureListControl, andplusFAQItemsControlare still consumed by non-experiment surfaces (settings/subscription, onboarding, internal helpers) and left in place.Test plan
pnpm --filter shared lintpnpm --filter webapp lintnode ./scripts/typecheck-strict-changed.js/plus, sidebar, custom-feed empty state, and Plus user badge tooltip render with the new copy.Made with Cursor
Preview domain
https://chore-remove-plus-api-landing-fl.preview.app.daily.dev