feat(feed-settings): add pin highlights to top toggle#6024
Merged
Conversation
Adds a Switch in the Feed Settings General tab that flips the new highlightsFirstEnabled Settings flag. When on, the API forwards highlights_first to the feed service so the highlight is pinned to the first position; otherwise it stays at its current random spot within the first half.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
The file was touched only to add the highlights-first Switch subsection. Pre-existing strict violations (auth user / feed optionality, Button prop mismatches, defaultFeedId null vs undefined) live on unrelated lines and should be addressed in a dedicated cleanup PR, matching the established pattern in the skip list (e.g. marketing folder consolidation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
highlightsFirstEnabledvia the existingupdateUserSettingsmutation (same plumbing asclickbaitShieldEnabled).highlights_firstto the feed service so the highlight placeholder is pinned to the first position on the first page; otherwise it stays at its current random index within the first half.Final repo of a 3-PR change:
Test plan
pnpm --filter @dailydotdev/shared linton my touched files — clean (graphql/settings.ts,FeedSettingsGeneralSection.tsx,lib/log.ts,lib/labels.ts)pnpm --filter @dailydotdev/shared typecheckon my touched files — clean (pre-existing TS debt in unrelated files)Notes
clickbaitShieldEnabled).Preview domain
https://feat-highlights-first-toggle.preview.app.daily.dev