Replace LightExpression TryEmit parent flags plumbing with compiler-context emit stack#524
Closed
Replace LightExpression TryEmit parent flags plumbing with compiler-context emit stack#524
TryEmit parent flags plumbing with compiler-context emit stack#524Conversation
Agent-Logs-Url: https://github.com/dadhi/FastExpressionCompiler/sessions/600fa5f1-1f8e-4c21-a2d6-bb68914c777a Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dadhi/FastExpressionCompiler/sessions/600fa5f1-1f8e-4c21-a2d6-bb68914c777a Co-authored-by: dadhi <39516+dadhi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace ParentFlags with stack of Expressions in TryEmit methods
Replace LightExpression Apr 20, 2026
TryEmit parent flags plumbing with compiler-context emit stack
Owner
|
Bads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TryEmitonly received a reducedParentFlagsview plus the immediate expression, which made custom emitters context-poor and forced parent-state plumbing through many call sites. This change centralizes emit context inCompilerContextby tracking the active expression stack so emitters can inspect the full parent chain directly.Compiler emit context
CompilerContextfor:CurrentEmitExpressionCurrentParentFlagsEmitExpressionCountGetEmitExpression(int indexFromCurrent)Emitter flow
EmittingVisitor.TryEmit(...)to push/pop emit context around each expression emission.LightExpression intrinsic API
ParentFlags parentparameter from LightExpression intrinsicExpression.TryEmit(...).CompilerContextinstead of relying on a caller-supplied flag snapshot.TryEmitparameter surface and aligns intrinsic emitters with centralized context access.Regression coverage