Skip to content

Emit rem.un for unsigned modulo expressions #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dadhi merged 2 commits into from
Apr 21, 2026
+29 −2
Merged

Emit rem.un for unsigned modulo expressions #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94abb3c
Initial plan
Copilot Apr 20, 2026
70d2be2
Fix unsigned modulo opcode emission
Copilot Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FastExpressionCompiler/FastExpressionCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5929,7 +5929,7 @@ private static bool TryEmitArithmeticOperation(Type leftType, Type rightType, Ex
ExpressionType.Multiply => OpCodes.Mul,
ExpressionType.MultiplyChecked => exprType.IsUnsigned() ? OpCodes.Mul_Ovf_Un : OpCodes.Mul_Ovf,
ExpressionType.Divide => OpCodes.Div,
ExpressionType.Modulo => OpCodes.Rem,
ExpressionType.Modulo => exprType.IsUnsigned() ? OpCodes.Rem_Un : OpCodes.Rem,
ExpressionType.And => OpCodes.And,
ExpressionType.Or => OpCodes.Or,
ExpressionType.ExclusiveOr => OpCodes.Xor,
Expand Down
29 changes: 28 additions & 1 deletion test/FastExpressionCompiler.UnitTests/ArithmeticOperationsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Numerics;
using System.Reflection.Emit;

#if LIGHT_EXPRESSION
using static FastExpressionCompiler.LightExpression.Expression;
Expand All @@ -18,6 +19,7 @@ public int Run()
Can_modulus_custom_in_Action();
Can_add_string_and_not_string();
Can_modulus_custom();
Can_modulus_with_unsigned_block_local_variable();
Can_sum_bytes_converted_to_ints();
Can_sum_signed_bytes_converted_to_ints();
Can_sum_all_primitive_numeric_types_that_define_binary_operator_add();
Expand Down Expand Up @@ -47,7 +49,7 @@ public int Run()
Can_calculate_arithmetic_operation_with_vectors();
Can_add_strings();

return 29;
return 30;
}

public void Can_sum_bytes_converted_to_ints()
Expand Down Expand Up @@ -229,6 +231,31 @@ public void Can_modulus()
Asserts.AreEqual(1, f(7, 6));
}

public void Can_modulus_with_unsigned_block_local_variable()
{
var b = Parameter(typeof(uint), "b");
var a = Variable(typeof(uint), "a");
var expr = Lambda<Func<uint, uint>>(
Block(new[] { a },
Assign(a, Constant(0x80000000u)),
Modulo(a, b)),
b);

var fs = expr.CompileSys();
var ff = expr.CompileFast(true, CompilerFlags.EnableDelegateDebugInfo);

Asserts.AreEqual(2u, fs(3u));
Asserts.AreEqual(2u, ff(3u));
ff.AssertOpCodes(
OpCodes.Ldc_I4,
OpCodes.Stloc_0,
OpCodes.Ldloc_0,
OpCodes.Ldarg_1,
OpCodes.Rem_Un,
OpCodes.Ret
);
}


public void Can_bit_or_1()
{
Expand Down
Loading