Type a run response state as RunState - #358
Merged
Merged
Conversation
RunResponse pinned state to a Literal of six states while RunState declares seven, and from_run silenced the mismatch with a type: ignore. from_run is on the author surface, so an app holding an orphaned run got a validation error instead of a response. The field takes RunState now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunResponse.statepinned the state to aLiteralof six values whileRunStatedeclares seven.from_runsilenced the mismatch with a# type: ignore.RunResponseandfrom_runare on the author surface, so an app that held an orphaned run got aValidationErrorinstead of a response. The field takesRunStatenow, so every state a run can derive projects.The read side is unaffected: an orphaned run has no
workflow_statusrow, so it never matches a subject and never reaches a timeline.