Let a subject link work inside a value - #357
Merged
Merged
Conversation
A Link with subject= rendered as dead text in a table cell, a fact, or a list item. The value renderer knew the page and url destinations only, so the subject destination fell through to plain text. One control now draws every link, wherever it sits. A value passes its own text as the label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.Link(subject=…)worked as a block. Inside aTextValueit passed every check on the server and then rendered as plain text: the value renderer knew thepageandurldestinations only, so a subject link in a table cell, a fact, or a list item was not clickable.The block renderer and the value renderer were the same control minus one branch. They are one control now. A value passes its own text as the label; a link block keeps its own.
A test covers a subject link in a list item.