Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions .github/workflows/format-suggest.yaml
Original file line number Diff line number Diff line change
@@ -1,30 +1,26 @@
# Workflow derived from https://github.com/posit-dev/setup-air/tree/main/examples

on:
# Using `pull_request_target` over `pull_request` for elevated `GITHUB_TOKEN`
# privileges, otherwise we can't set `pull-requests: write` when the pull
# request comes from a fork, which is our main use case (external contributors).
#
# `pull_request_target` runs in the context of the target branch (`main`, usually),
# rather than in the context of the pull request like `pull_request` does. Due
# to this, we must explicitly checkout `ref: ${{ github.event.pull_request.head.sha }}`.
# This is typically frowned upon by GitHub, as it exposes you to potentially running
# untrusted code in a context where you have elevated privileges, but they explicitly
# call out the use case of reformatting and committing back / commenting on the PR
# as a situation that should be safe (because we aren't actually running the untrusted
# code, we are just treating it as passive data).
# https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/
pull_request_target:
# CI-VERIFY / DRY-RUN ONLY -- DO NOT MERGE. The real workflow uses
# `pull_request_target` (elevated token for fork PRs). But pull_request_target
# runs the workflow file from the repo's DEFAULT branch (main), so a modified
# format-suggest cannot be tested via a PR without touching main. To exercise
# the style + reviewdog logic end-to-end, this middle branch switches the
# trigger to `pull_request` (which uses the PR's own workflow file) and scopes
# it to PRs whose base is this middle branch -- i.e. only the outermost test PR
# triggers it, so this middle PR itself runs no checks.
pull_request:
branches:
- claude/ubuntu-26-arm64-gha-ezzy7y-fmt-base

name: format-suggest.yaml

jobs:
format-suggest:
name: format-suggest
runs-on: ubuntu-26.04
# Only run this job if changes come from a fork.
# We commit changes directly on the main repository.
if: github.event.pull_request.head.repo.full_name != github.repository
# DRY-RUN: fork-only gate removed so this runs for the same-repo test PR.
# (The trigger's branches filter already scopes this to the outermost PR.)

permissions:
# Required to push suggestion comments to the PR
Expand Down
Loading