Fix cursorless Generate Thought test setup - #4978
Merged
raineorshine merged 1 commit intoAug 18, 2026
Merged
Conversation
Construct the cursorless multiselect directly instead of relying on cursorBack, whose multicursor behavior changed before the test merged.\n\nCo-Authored-By: Codex GPT-5 (unknown context) <noreply@openai.com>
marcus-pousette
marked this pull request as draft
August 17, 2026 22:33
marcus-pousette
marked this pull request as ready for review
August 17, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4936 added a cursorless-multiselect test that calls
cursorBack()after creating the multicursor selection. #4938 merged first and changed Back to operate on the multicursor selection; for root-level selections it intentionally does nothing, so the hidden cursor remains set.This causes the current
mainTest workflow and unrelated PRs such as #4972 to fail at the same assertion:mainfailureSolution
Construct the supported cursorless multiselect directly with
setCursor(null)before adding the multicursors. This keeps the test focused on Generate Thought rather than depending on Back semantics.Verification
yarn test --run src/commands/__tests__/generateThought.ts— 14/14 passedyarn eslint src/commands/__tests__/generateThought.tsyarn prettier --check src/commands/__tests__/generateThought.tsyarn lint:tsc --pretty false