fix(discovery-plugin): startup plugin pings are serial, add more fault-tolerance#1496
Merged
andrewazores merged 8 commits intocryostatio:mainfrom May 4, 2026
Merged
Conversation
…fresh jobs Ping plugins in batches to avoid causing a thundering herd of plugins attempting to re-register with Cryostat
andrewazores
force-pushed
the
registration-herd
branch
from
5fe644f to
7e26a41
Compare
jtolentino1
approved these changes
May 4, 2026
Member
jtolentino1
left a comment
jtolentino1
left a comment
There was a problem hiding this comment.
LGTM. See: cryostatio/cryostat-agent#860 (review)
Member
Author
|
/build_test |
|
Workflow started at 5/4/2026, 4:33:26 PM. View Actions Run. |
|
No WebSocket notifications schema changes detected. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build: https://github.com/cryostatio/cryostat/actions/runs/25342024421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #1483
Description of the change:
Further improvements to the discovery plugin registration cycle. After the recent Cryostat and Agent PRs the situation is stable when Agents register with Cryostat, and Agents going offline and being replaced is working as expected and reliably. However, if a very large number of Agents come online simultaneously then Cryostat can get overwhelmed with the flood of requests, which can cause threadpool or JDBC connection pool starvation issues or even OOM crashes.