Skip to content

Upgrade toolchain to nightly-2026-04-21#2052

Merged
Lysxia merged 1 commit intomasterfrom
nightly-2026-04
Apr 22, 2026
Merged

Upgrade toolchain to nightly-2026-04-21#2052
Lysxia merged 1 commit intomasterfrom
nightly-2026-04

Conversation

@Lysxia
Copy link
Copy Markdown
Collaborator

@Lysxia Lysxia commented Apr 21, 2026

  • instantiate wraps its result in Unnormalized<_> so this is a good opportunity to revisit how we handle normalization
  • DefKind::Const and AssocConst now carry a boolean to keep track of whether they are "suitable for generics", if I understand correctly. I don't think it affects us (hence this PR just ignores that boolean), but while looking into it I learned that people working on const generics have at least thought about having a termination checker to enable more powerful const generics: https://hackmd.io/OsVAAEgOS2ajDwxg44kN-A?view
  • the only coma diff shows that AtomicBool has become a synonym for Atomic<Bool> (etc.) which seems relevant to concurrency folks core: make atomic primitives type aliases of Atomic<T> rust-lang/rust#153015

@Lysxia
Copy link
Copy Markdown
Collaborator Author

Lysxia commented Apr 21, 2026

I've been looking into removing Namer::normalize (as there is a TODO saying to remove it), the following uses remain:

  • normalize RPITs in the result of a function
  • normalize ADT field types

The first one seems not too hard to avoid, but the second seems more essential.

I got rid of other uses by pushing normalization to the translation phase (MIR -> FMIR and Pearlite THIR -> Term), although it feels rather fragile... The tests pass but I wouldn't be surprised if there are still terms containing unnormalized or unerased types that we just happen to not look at.

@Lysxia Lysxia marked this pull request as ready for review April 21, 2026 15:35
@Lysxia Lysxia force-pushed the nightly-2026-04 branch 2 times, most recently from 177a3dd to 6680faa Compare April 21, 2026 15:53
@Lysxia
Copy link
Copy Markdown
Collaborator Author

Lysxia commented Apr 21, 2026

I think I'm about done cleaning up the normalizes for this PR.

@Lysxia Lysxia enabled auto-merge April 22, 2026 09:00
@Lysxia Lysxia merged commit 0d543b3 into master Apr 22, 2026
9 checks passed
@Lysxia Lysxia deleted the nightly-2026-04 branch April 22, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant