Adds initial draft for separate compilation#96
Adds initial draft for separate compilation#96VictorEijkhout wants to merge 28 commits intocplusplus:masterfrom
Conversation
create from skeleton
Edits after SG20 committee discussion.
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
Nice first draft for the separate compilation topic.
Most of my comments are just align syntax/file structure with the rest of the topics. Overall, this topic highlights already many important points about the topic.
| #### Points to cover | ||
|
|
||
| 1. Cover the mechanisms for include and library paths to your own code, as well as discovery mechanisms for external libraries. | ||
|
|
There was a problem hiding this comment.
From reading the ASBATs, we probably need more points to cover that contain the skills necessary to reach the ASBAT level.
There was a problem hiding this comment.
Addressed with the latest commit.
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
|
refs #8 |
intro text moved to motivation
remove mention of text editor
sub indent
turn enum list into item
remove incorrect sentence
better caption
better caption
caption improved
proposal
TOC in sync with captions
added sentence about translation units
extern variable mention removed
|
@vulder and @ronchaine we did a pass in today's meeting. Please have a look. |
vulder
changed the title
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
LGTM
I'm mark the topic tentative ready and put it on the agenda for the next online SG20 meeting.
|
@vulder was this pr discussed in the next online SG20 meeting? |
|
Yes, it will be in the list of PRs we review in the next meeting. (All PRs marked tentatively ready will be discussed in the next meeting) |
|
@diehlpk Last time we discussed this PR, the only thing that was left is that the points-to-cover did not contain the necessary material to actually fulfill the ASSBATs. Could you please take a quick look at this in the next NA-Group meeting, so we can do a final vote on this in the next SG20 meeting. |
|
@vulder we addressed the last comment in today's meeting. |
5 participants
First attempt at "separate compilation" module.