Constructors#121
Open
diehlpk wants to merge 18 commits intocplusplus:masterfrom
Open
Conversation
Discussion with the US group
Mention unit testing
Move building a lib and link it to a C++ executable to the main level
Contributor
Author
rwdougla
reviewed
Sep 25, 2025
Contributor
Author
|
refs #52 |
vulder
requested changes
Apr 19, 2026
| #### Points to cover | ||
|
|
||
| * Overloading of constructors and default arguments | ||
| * Copy constructor and destructor |
Member
There was a problem hiding this comment.
The destructor part could be mentioned here but should also be linked to the destructors topic.
Contributor
Author
There was a problem hiding this comment.
We do not have a topic for destructors yet.
Contributor
Author
There was a problem hiding this comment.
We would like to propose to add the destructor topic to this PR since we believe the belong together.
Co-authored-by: Florian Sattler <vuld3r@gmail.com>
Contributor
Author
|
@vulder we addressed the comments in today's meeting. We will work on the other two comments for the PRs in our next meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft by the North American team.