Skip to content

adding files and folders as well as right-click with firebase integration #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meher0704 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

adding files and folders as well as right-click with firebase integration #200

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd7ec94
adding files and folders as well as right-click with firebase integra…
MeherKhurana Jun 10, 2025
4da68bc
try-1 with diff union - fail ? file saving firebase
MeherKhurana Jun 10, 2025
9b0ea8e
reversed changes
MeherKhurana Jun 10, 2025
90c6167
fixed 8/10
MeherKhurana Jun 11, 2025
c696ff1
fixed files loading
MeherKhurana Jun 11, 2025
48a825a
all issues fixed debug done
MeherKhurana Jun 11, 2025
0437bdc
some fixes
MeherKhurana Jun 13, 2025
ccff63e
done
MeherKhurana Jun 13, 2025
4cacbf8
nicer
MeherKhurana Jun 13, 2025
9165c97
centered empty state
MeherKhurana Jun 13, 2025
60a3232
added melt ui drop down instead
MeherKhurana Jun 13, 2025
ffee6aa
cleaned code
MeherKhurana Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Stored in /users/{uid}/files/{fileID} in Firebase.
*/
export type UserFile = {
type: string;
Copy link
Copy Markdown
Member

@thecodingwizard thecodingwizard Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "type"?

Copy link
Copy Markdown
Author

@meher0704 meher0704 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it determines if the user is storing is a file or a folder

Copy link
Copy Markdown
Member

@thecodingwizard thecodingwizard Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. what do you think about storing them separately: /users/{uid}/files/{fileID} and /users/{uid}/folders/{folderID}? or even /users/{uid}/files/folders/{folderID} if you prefer.

That way we can type them differently. In particular, some fields of files are not relevant for folders, like "language."

Copy link
Copy Markdown
Author

@meher0704 meher0704 Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well storing separately will make the code significantly more complicated;
i would suggest

export type File = {
kind: "file";
id: string;
name: string;
language?: string;
// File-specific fields
};

export type Folder = {
kind: "folder";
id: string;
name: string;
// Folder-specific fields
};

export type UserItem = File | Folder;

using a discriminated union

so that it doesn't become as complex and still is one file

Copy link
Copy Markdown
Member

@thecodingwizard thecodingwizard Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'm ok with that!

Copy link
Copy Markdown
Member

@thecodingwizard thecodingwizard Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meher0704 does this still need to be updated?

id: string; // not stored in database; injected by client
lastAccessTime: number;
title: string;
Expand Down
Loading