fix: add NULL check for GvIOp in XML_Do_External_Parse#259
Draft
fix: add NULL check for GvIOp in XML_Do_External_Parse#259
Conversation
GvIOp() returns NULL when a glob has no IO slot (e.g., an unopened filehandle). The two call sites in XML_Do_External_Parse passed the result directly to newRV_inc(), which would dereference NULL and segfault. Now we check for NULL and croak with a descriptive message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 75.73% 76.45% +0.72%
==========================================
Files 1 1
Lines 1092 1096 +4
Branches 342 344 +2
==========================================
+ Hits 827 838 +11
+ Misses 59 52 -7
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent segfault when ExternEnt handler returns an unopened filehandle (glob with no IO slot).
Why
GvIOp()returns NULL when a glob has never been opened. Both call sites inXML_Do_External_Parse(lexical glob ref at L2357 and bare glob at L2361) passed the result directly tonewRV_inc(NULL), which dereferences the NULL pointer — instant segfault. While most handlers return properly opened filehandles, a buggy or incomplete handler could trigger this crash with no useful diagnostic.How
Extract the
GvIOp()result into a localIO *iovariable and check for NULL before use. On NULL,croak()with a descriptive message instead of dereferencing.Testing
t/extern_ent_lexical_glob.t: one for bare unopened glob, one for scalar ref (different code path but same area)🤖 Generated with Claude Code