fix: add use warnings to all production modules#256
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: add use warnings to all production modules#256toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
Parser.pm and the five Style modules (Debug, Objects, Stream, Subs, Tree) had use strict but not use warnings. Expat.pm is intentionally excluded — it already documents why warnings are not enabled globally (namespace methods use int() on strings with locally scoped no warnings "numeric"). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 1 1
Lines 1092 1092
Branches 342 342
=======================================
Hits 827 827
Misses 59 59
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
use warningsto Parser.pm and all five Style modules.Why
These modules had
use strictbut notuse warnings— a historical artifact from beforewarningswas standard practice. Without it, subtle issues (uninitialized values, numeric/string mismatches) are silently swallowed at runtime.Expat.pm is intentionally excluded: it documents why warnings are not enabled globally (namespace methods use
int()on strings, requiring locally scopedno warnings "numeric").How
One-line addition to each of the 6 files. No behavioral changes.
Testing
Full test suite passes with no new warnings.
🤖 Generated with Claude Code