fix: use bare return instead of return undef in list-context methods#255
Draft
fix: use bare return instead of return undef in list-context methods#255
Conversation
ContentModel::children() uses "return undef" which returns (undef) in list context instead of an empty list. This means @kids = $model->children yields a one-element list for EMPTY/ANY models, causing silent bugs in code that checks @kids for emptiness. This test fails against the current code, proving the bug exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ContentModel::children() and expand_ns_prefix() used "return undef" which produces (undef) — a one-element list — in list context. This is a classic Perl footgun: code like "my @kids = $model->children" gets a truthy list for EMPTY/ANY models that have no children. Bare "return" correctly gives () in list context and undef in scalar context, preserving backward compatibility for scalar callers while fixing the list-context bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 1 1
Lines 1092 1092
Branches 342 342
=======================================
Hits 827 827
Misses 59 59
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
return undefwith barereturninContentModel::children()andexpand_ns_prefix().Why
return undefin list context produces(undef)— a one-element list — not an empty list. This meansmy @kids = $model->childrenon an EMPTY or ANY model gives a truthy result, silently breaking code that checks@kidsfor emptiness. This is Perl::Critic policySubroutines::ProhibitExplicitReturnUndef.How
Bare
returngives()in list context andundefin scalar context — fixing the list-context bug while preserving scalar-context backward compatibility.Testing
t/return_undef_list_context.t(6 tests) — first commit demonstrates the bug (fails), second commit fixes it (passes).🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 65 insertions(+), 2 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline