test: add use strict and use warnings to test files#253
Draft
test: add use strict and use warnings to test files#253
Conversation
Nine test files were missing strict, warnings, or both. This makes them consistent with the rest of the test suite and catches accidental bareword or undeclared variable issues at test time. - 6 files: add both use strict and use warnings - 3 files: add use warnings (already had use strict) - t/file.t: add missing my on $parser - t/file_open_scalar.t: quote module name in use-if for strict compat Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 75.73% 75.73%
=======================================
Files 1 1
Lines 1092 1092
Branches 342 342
=======================================
Hits 827 827
Misses 59 59
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add missing
use strictanduse warningsto 9 test files.Why
These test files were the only ones in the suite without strict/warnings, making them inconsistent and allowing silent issues like undeclared variables (
$parserint/file.t).How
use strictanduse warningsuse warnings(already haduse strict)t/file.t: added missingmyon$parsert/file_open_scalar.t: quotedTest::Moreinuse iffor strict compatibilityTesting
Full
make testpasses — 59 test programs, 677 subtests, 0 failures.🤖 Generated with Claude Code