refactor: simplify Makefile.PL EUMM version guards#35
Draft
Conversation
Remove version-conditional guards for LICENSE (6.3002) and TEST_REQUIRES (6.64). Instead, declare ExtUtils::MakeMaker 6.64 in CONFIGURE_REQUIRES so CPAN clients auto-upgrade before running Makefile.PL. This eliminates all $ExtUtils::MakeMaker::VERSION checks and the TEST_REQUIRES-to-PREREQ_PM fallback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove
$ExtUtils::MakeMaker::VERSIONconditionals from Makefile.PL by requiring EUMM >= 6.64 upfront.Why
The file had version-guarded blocks for
LICENSE(needs 6.3002) andTEST_REQUIRES(needs 6.64), plus a fallback that merged test deps intoPREREQ_PMfor ancient toolchains. EUMM 6.64 shipped with Perl 5.19.1 (2013) — any system still on an older EUMM will have it auto-upgraded viaCONFIGURE_REQUIRESbeforeMakefile.PLruns.How
CONFIGURE_REQUIRES => { 'ExtUtils::MakeMaker' => '6.64' }so CPAN clients upgrade EUMM before configure phase$ExtUtils::MakeMaker::VERSIONconditionalsLICENSEandTEST_REQUIRESdirectlyprovideswithMM->parse_version()— that's the correct EUMM pattern for multi-package distsTesting
make test— 183 tests pass. VerifiedMYMETA.jsonhas correct prereq phases (configure, runtime, test all separate).🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 7 insertions(+), 7 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline