fix: add missing build artifact patterns to MANIFEST.SKIP#79
Draft
fix: add missing build artifact patterns to MANIFEST.SKIP#79
Conversation
Add blib/, pm_to_blib, and Makefile.old to MANIFEST.SKIP so that make manifest produces a clean MANIFEST even when run in a built tree. Also escape regex metacharacters in existing patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add `blib/`, `pm_to_blib`, and `Makefile.old` to MANIFEST.SKIP.
Why: Running `make manifest` in a built tree (after `perl Makefile.PL && make`) pollutes MANIFEST with build artifacts like `blib/lib/Net/ACME2.pm` and `pm_to_blib`. This makes `make manifest` only safe to run in a pristine checkout, which is easy to forget.
How: Added the three missing patterns. Also escaped regex metacharacters in existing entries (`MANIFEST.bak` → `MANIFEST\.bak`, etc.) for correctness.
Testing: Ran `make manifest` in a fully built tree — MANIFEST stays clean.
🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 6 insertions(+), 3 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline