fix: sync error and expires in Order/Authorization update()#75
Draft
fix: sync error and expires in Order/Authorization update()#75
Conversation
Order::update() only synced status and certificate, silently dropping the error field that ACME servers send when an order goes invalid (RFC 8555 §7.1.3). Users polling an invalid order had no way to find out why it failed. Also sync expires in both Order and Authorization update(), since servers may update expiry times between polls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Order and Authorization
update()methods now sync all server-mutable fields, not just a subset.Why
When an ACME order becomes "invalid", the server includes an
errorfield (RFC 7807 problem document) explaining what went wrong.Order::update()only syncedstatusandcertificate, silently dropping the error. Users polling an invalid order had no way to diagnose the failure.Similarly,
expireswas never synced in eitherOrder::update()orAuthorization::update(), meaning expiry times went stale after polling.How
errorandexpirestoOrder::update()field listexpirestoAuthorization::update()field listerrorto Order's_ACCESSORSwith POD documentationTesting
🤖 Generated with Claude Code
Quality Report
Changes: 5 files changed, 202 insertions(+), 3 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline