Draft
Conversation
39 tests covering the crypto backend abstraction layer: constructor (PEM and DER), key type detection, JWK export, thumbprint generation, signing (RSA and ECDSA), signature verification round-trip, PEM/DER equivalence, and $@ preservation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Comprehensive test coverage for
Net::ACME2::AccountKey, the crypto backend abstraction layer that had zero dedicated tests.Why
AccountKey is on the critical path for every ACME operation — it handles key parsing, backend selection (CryptX vs Crypt::Perl), signing, and JWK export. All existing tests only exercised it indirectly through JWTMaker or the mock ACME server.
How
39 tests covering:
$@preservation across constructor (CryptX eval guards)Testing
make test— all 346 tests pass (21 files including this new one).🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 279 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline