fix: cleanup items from async refactor review#65
Merged
Conversation
- Remove _sync_io flag from HTTP.pm (set but never read) - Remove commented-out DESTROY sub from ACME2.pm - Remove commented-out Content-Type line from HTTP.pm Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trailing CRLF in HTTP headers produces an empty line after split. Without this guard, the empty line would be parsed as a malformed header and trigger an uninitialized-value warning on $value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename _directory_promise to _directory_cache — in sync mode this caches a plain hashref, not a promise, so the old name was misleading - Add comment explaining why badNonce retry uses mutation on _retries_left instead of local() (promise chain compatibility) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the polish items identified in the async HTTP refactor review (PR #62). These are cleanup items — no behavioral changes.
Fixes #63
Changes
_sync_ioflag from HTTP.pm constructor (set but never read)DESTROYsub from ACME2.pmContent-Typeline from HTTP.pm_imitate_http_tinyheader parsing_directory_promiseto_directory_cachefor clarity in sync modelocal(promise chain compatibility)Test plan
make test)perl -Ilib -c)Generated by Kōan /fix
Quality Report
Changes: 3 files changed, 7 insertions(+), 12 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline