fix: restrict octal parsing to valid octal digits#59
Draft
Conversation
Values like "08" and "09" matched the octal regex /^0(\d+)$/ but contained digits invalid in octal (8, 9). Perl's oct() silently returned 0 for these, so `stty intr 08` would disable the interrupt character instead of setting it to 8. Narrow the regex to /^0([0-7]+)$/ so inputs with 8/9 fall through to the decimal path and produce the expected value. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
_parse_char_valuesilently returning 0 for values like"08"and"09".Why
The octal regex
/^0(\d+)$/matched any digits after a leading zero, including8 and 9. Perl's
oct()rejects these as illegal octal digits and returns 0 —meaning
stty intr 08would disable the interrupt character instead ofsetting it to 8. On Linux where
_POSIX_VDISABLEis 0, this is especiallydangerous: you silently lose the ability to interrupt processes.
How
Narrowed the octal regex to
/^0([0-7]+)$/. Values containing 8 or 9 nowfall through to the decimal integer path and return the expected value.
Testing
Added 3 test cases (
08,09,019). Full suite: 148 tests pass.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 9 insertions(+), 2 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: 1 issue(s)
Generated by Kōan post-mission quality pipeline