Skip to content

fix: use Carp for error messages to report caller location #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use Carp for error messages to report caller location #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/IO/Stty.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package IO::Stty;
use strict;
use warnings;

use Carp;
use POSIX;

our $VERSION = '0.08';
Expand Down Expand Up @@ -475,7 +476,7 @@ sub _parse_char_value {
return ord($val);
}

warn "IO::Stty: unrecognized character value '$val'\n";
carp "IO::Stty: unrecognized character value '$val'";
return 0;
}

Expand All @@ -500,7 +501,7 @@ From comments:
sub stty {
my $tty_handle = shift; # This should be a \*HANDLE

@_ or die("No parameters passed to stty");
@_ or croak("No parameters passed to stty");

# Notice fileno() instead of handle->fileno(). I want it to work with
# normal fhs.
Expand All @@ -513,7 +514,7 @@ sub stty {
# make a terminal object.
my ($termios) = POSIX::Termios->new();
unless ( $termios->getattr($file_num) ) {
warn "Couldn't get terminal parameters for '$tty_name', file num ($file_num)";
carp "Couldn't get terminal parameters for '$tty_name', file num ($file_num)";
return undef;
}
my ($c_cflag) = $termios->getcflag;
Expand Down Expand Up @@ -771,20 +772,20 @@ sub stty {
# Speed?
if ( $_ eq 'ospeed' ) {
my $rate = shift(@parameters);
exists $BAUD_RATES{$rate} or warn "IO::Stty::stty: unknown baud rate '$rate'\n";
exists $BAUD_RATES{$rate} or carp "IO::Stty: unknown baud rate '$rate'";
$ospeed = $BAUD_RATES{$rate} if exists $BAUD_RATES{$rate};
next;
}
if ( $_ eq 'ispeed' ) {
my $rate = shift(@parameters);
exists $BAUD_RATES{$rate} or warn "IO::Stty::stty: unknown baud rate '$rate'\n";
exists $BAUD_RATES{$rate} or carp "IO::Stty: unknown baud rate '$rate'";
$ispeed = $BAUD_RATES{$rate} if exists $BAUD_RATES{$rate};
next;
}

# Default.. parameter hasn't matched anything
# print "char:".sprintf("%lo",ord($_))."\n";
warn "IO::Stty::stty passed invalid parameter '$_'\n";
carp "IO::Stty: invalid parameter '$_'";
}

# What a pain in the ass! Ok.. let's write the crap back.
Expand Down
Loading