refactor: replace flag if/elsif chains with lookup tables

[toddr-bot]

What

Replace 30+ individual if/elsif statements in stty() and show_me_the_crap() with data-driven lookup tables.

Why

The flag-handling code repeated the same bit-manipulation pattern for every POSIX flag — each one a copy-paste with only the constant name changing. This made adding new flags error-prone (need changes in two places) and the code harder to scan. The igncr display bug (#50) is a direct consequence of this pattern: easy to add a flag to the setter but forget the display.

How

Six package-level data structures replace the if/elsif chains:

• %CFLAGS, %IFLAGS, %LFLAGS, %OFLAGS — hash lookup for the setting loop (aliases like hup→HUPCL and crterase→ECHOE are just extra entries)
• %CC_NAMES — control character name → hash key mapping
• @CFLAG_DISPLAY, @LFLAG_DISPLAY, @IFLAG_DISPLAY — ordered arrays for display output (preserving exact output format)

Character size (cs5-cs8) and baud rate handling remain explicit since they have special mask-and-set semantics.

Testing

All 139 tests pass unchanged — exact output format and behavior preserved. Net code reduction: 26 lines (71 added, 97 removed).

🤖 Generated with Claude Code

---

Quality Report

Changes: 1 file changed, 71 insertions(+), 97 deletions(-)

Code scan: clean

Tests: passed (OK)

Branch hygiene: 1 issue(s)

• Branch is not pushed to remote

Generated by Kōan post-mission quality pipeline

[toddr-bot]

Rebase: refactor: replace flag if/elsif chains with lookup tables

Branch koan.toddr.bot/refactor-flag-tables rebased onto main and force-pushed.

Diff: 1 file changed, 71 insertions(+), 98 deletions(-)

Actions

• Already-solved check: negative (confidence=high, reasoning=None of the recent commits on main describe replacing if/elsif chains with lookup tables — the commi)
• Resolved merge conflicts (1 round(s))
• Rebased koan.toddr.bot/refactor-flag-tables onto upstream/main
• Force-pushed koan.toddr.bot/refactor-flag-tables to upstream
• CI check enqueued (async)

CI

CI will be checked asynchronously.

---

Automated by Kōan

[toddr]

@toddr-bot rebase this is a good idea but it's breaking tests. be sure they pass before submitting

t/01-parse-char-value.t ..... ok
t/02-combination-aliases.t .. skipped: IO::Pty required for terminal tests

#   Failed test '-a output includes igncr flag'
#   at t/02-show-me-the-crap.t line 108.
#                   'speed 9600 baud;
# intr = ^C; quit = ^\; erase = ^?; kill = ^U;
# eof = ^D; eol = <undef>; start = ^Q; stop = ^S; susp = ^Z;
# min = 1; time = 0;
# -clocal -cread -cstopb -hupcl -parenb -parodd cs8
# -echo -echoe -echok -echonl -icanon -isig -noflsh -tostop -iexten -opost
# -brkint -ignbrk -ignpar -parmrk -inpck -istrip -inlcr -icrnl -ixon -ixoff
# '
#     doesn't match '(?^:-igncr)'
# Looks like you failed 1 test of 9.
t/02-show-me-the-crap.t ..... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/9 subtests 
t/02-single-arg.t ........... skipped: IO::Pty required for terminal tests
t/99-pod-coverage.t ......... ok
t/99-pod.t .................. ok
t/baud-rates.t .............. ok

Test Summary Report
-------------------
t/02-show-me-the-crap.t   (Wstat: 256 (exited 1) Tests: 9 Failed: 1)
  Failed test:  9
  Non-zero exit status: 1
Files=11, Tests=86,  1 wallclock secs ( 0.03 usr  0.02 sys +  0.50 cusr  0.11 csys =  0.66 CPU)
Result: FAIL
Failed 1/11 test programs. 1/86 subtests failed.
make: *** [Makefile:859: test_dynamic] Error 255
Error: Process completed with exit code 2.

[toddr-bot]

Rebase: refactor: replace flag if/elsif chains with lookup tables

Branch koan.toddr.bot/refactor-flag-tables rebased onto main and force-pushed.

Diff: 1 file changed, 71 insertions(+), 98 deletions(-)

Review feedback was analyzed and applied.

Changes

Summary: Added missing [IGNCR,'igncr'] entry to @IFLAG_DISPLAY array in lib/IO/Stty.pm. The igncr flag was present in the %IFLAGS setter table but was accidentally omitted from the display table, causing -a output to not show the igncr flag. This is exactly the bug (#50) that the refactor was meant to prevent — the display list and setter list got out of sync.

Actions

• Already-solved check: negative (confidence=high, reasoning=None of the recent commits on main refactor the if/elsif chains into lookup tables — they only fix i)
• Rebased koan.toddr.bot/refactor-flag-tables onto upstream/main
• Applied review feedback
• Force-pushed koan.toddr.bot/refactor-flag-tables to upstream
• CI check enqueued (async)

CI

CI will be checked asynchronously.

---

Automated by Kōan

[toddr-bot]

This PR is superseded by #55, which includes the same refactoring plus the Windows portability fix (BEGIN/eval wrapper). If you merge #55, this one can be closed.

The test failures you reported have been addressed in #55's second commit.

[toddr-bot]

This PR is superseded by #55, which includes the same refactor-to-lookup-tables change plus a Windows portability fix (wrapping the POSIX constant initialization in eval {} blocks so the module still loads on Windows where termios constants die when called). All tests pass on #55.

I'd suggest closing this one in favor of #55.