Skip to content

Add a metric for settlement fee and surplus calculation failures #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
squadgazzz wants to merge 2 commits into
base: main
Choose a base branch
from
+35 −1
Open

Add a metric for settlement fee and surplus calculation failures #4674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbffb61
Add a settlement math error metric so fee calculation failures alert …
squadgazzz Jul 27, 2026
7a9681c
Publish the settlement math error series at zero so the first failure…
squadgazzz Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/autopilot/src/domain/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ pub struct Metrics {
/// Tracks settlements that couldn't be matched to the database solutions.
#[metric(labels("solver_address"))]
pub inconsistent_settlements: prometheus::IntCounterVec,

/// Tracks trades whose surplus, fee or fee breakdown calculation failed
/// and fell back to zeroed values.
#[metric(labels("kind"))]
pub settlement_math_errors: prometheus::IntCounterVec,
Comment thread
squadgazzz marked this conversation as resolved.
}

impl Metrics {
Expand Down
12 changes: 12 additions & 0 deletions crates/autopilot/src/domain/settlement/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ impl Settlement {
trade = %trade.uid(),
"possible incomplete surplus calculation",
);
Metrics::get()
.settlement_math_errors
.with_label_values(&["surplus"])
.inc();
num::zero()
});
surplus = surplus + trade_surplus;
Expand All @@ -118,6 +122,10 @@ impl Settlement {
trade = %trade.uid(),
"possible incomplete fee calculation",
);
Metrics::get()
.settlement_math_errors
.with_label_values(&["fee"])
.inc();
num::zero()
});
fee = fee + trade_fee;
Expand All @@ -128,6 +136,10 @@ impl Settlement {
trade = %trade.uid(),
"possible incomplete fee breakdown calculation",
);
Metrics::get()
.settlement_math_errors
.with_label_values(&["fee_breakdown"])
.inc();
trade::FeeBreakdown {
total: eth::Asset {
token: trade.sell_token(),
Expand Down
Loading