Remove CoW AMMs - #4624
Conversation
|
Reminder: Please update the DB Readme and comment whether migrations are reversible (include rollback scripts if applicable).
Resolved |
|
Claude encountered an error after 4m 1s —— View job PR Review: Remove CoW AMMs
The removal looks clean and consistent: the I flagged two rollout-coordination concerns as inline comments — neither is a logic bug, but both can break a deploy:
One behavioral note (not flagged, appears intentional): surplus-capturing JIT owners are no longer filtered by native-price availability in Given the PR is explicitly not meant to merge yet, these are mainly things to sequence correctly when you do execute. |
| /// surplus in the auction. | ||
| #[serde(default)] | ||
| pub cow_amm: CowAmmGroupConfig, | ||
| pub surplus_capturing_jit_order_owners: Vec<Address>, |
There was a problem hiding this comment.
the infra pr removes the fields and doesnt add any, do we actually need this or could we also remove this field and remove even more things?
There was a problem hiding this comment.
I think it's ok to leave the concept in the codebase (it still seems like a basic protocol feature we might want to reuse one day)
There was a problem hiding this comment.
i'd argue that we can just come back and re-add it when needed then, otherwise we just have code we're not using and adding noise
either way, doesnt need to be removed in this PR
There was a problem hiding this comment.
Normally I'd agree with this, but looking at how long it took us to add this feature in the first place, I would rather not rip it out to later re-discuss how it should be added again.
MartinquaXD
left a comment
There was a problem hiding this comment.
🧹
Not sure if we actually need to keep the surplus capturing jit order owner concept but removing this might also be a bit more involved. Starting by ripping out only the cow amm specific stuff is definitely the right call.
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
jmg-duarte
left a comment
There was a problem hiding this comment.
This has been disabled in prod already, it's g2g
Description
As we are stopping support for CoW AMMs, this PR removes all occurrences of the concept in our backend code base. It leaves the underlying protocol concept of "surplus capturing jit orders" (the idea that the protocol can define certain accounts, for which the solver can create arbitrary limit orders during the competition and execute them with surplus that counts towards their score), as this is relatively little overhead to maintain and potentially a useful concept down the line.
Note, I'm not intending to merge this PR right away (mainly wanted to get feedback and a feel if I'm missing anything). We still need to talk to solvers and the one remaining LP before we can execute on this.
Changes
How to test
CI
Related Issues
https://linear.app/cowswap/issue/BE-99/remove-cow-amm-support