-
Notifications
You must be signed in to change notification settings - Fork 183
Add onchain gas cost to trades and orders APIs #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmg-duarte
wants to merge
12
commits into
main
Choose a base branch
from
jmgd/order-trade-gas-cost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7bfa6fb
Add on-chain gas cost to trades API
jmg-duarte 8e6bae8
Add on-chain gas cost to orders API
jmg-duarte 3e73007
Merge branch 'main' into jmgd/order-trade-gas-cost
jmg-duarte 7b8ec28
Merge branch 'main' into jmgd/order-trade-gas-cost
jmg-duarte c5c4ff2
Merge branch 'main' into jmgd/order-trade-gas-cost
jmg-duarte ccc7a13
Address Claude comments about doc accuracy
jmg-duarte 8b17b89
Update DB migration
jmg-duarte 3688374
Update OpenAPI doc
jmg-duarte 5d0197d
Docs updates w.r.t. migration
jmg-duarte b1fa57e
Move server side query to DB
jmg-duarte 9881ff2
Address comments
jmg-duarte 70a833c
Merge branch 'main' into jmgd/order-trade-gas-cost
jmg-duarte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth double-checking the semantics here:
ORDER_GAS_COSTsums the order's gas across all of its fills globally, butget_by_tx(feeding/transactions/{tx}/orders) is a per-transaction view. For a partially-fillable order settled across multiple transactions, this endpoint will report the order's lifetime gas cost, not the portion attributable to$tx. A frontend summinggasCostover the orders in a tx to get a "transaction gas total" would over-count. Consistent with theOrderMetadata.gas_costfield definition (it's an order-level property), so likely acceptable — just flagging in case the per-tx endpoint is expected to be tx-scoped.