Conversation
Make mise the documented source of truth for repository CLI tools and guide agents through the required environment setup.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
@coveo/atomic
@coveo/atomic-hosted-page
@coveo/atomic-legacy
@coveo/atomic-react
@coveo/auth
@coveo/bueno
@coveo/create-atomic
@coveo/create-atomic-component
@coveo/create-atomic-component-project
@coveo/create-atomic-result-component
@coveo/create-atomic-rollup-plugin
@coveo/create-ui
@coveo/headless
@coveo/headless-react
@coveo/relay
@coveo/shopify
commit: |
There was a problem hiding this comment.
Pull request overview
Updates the repo’s agent-facing tooling documentation and mise configuration so contributors initialize the CLI toolchain via mise.toml instead of nvm/corepack.
Changes:
- Document
miseas the required toolchain manager inAGENTS.mdand forbidnvm/corepack/npx/npm. - Adjust
mise.tomlto enable idiomatic version files and make installs reproducible viapnpm install --frozen-lockfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mise.toml |
Switches toolchain configuration approach and tightens the install task to use a frozen lockfile. |
AGENTS.md |
Updates agent prerequisites to use mise and removes prior nvm/corepack guidance. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| 1. If `mise` is not installed, stop and ask the user to install it with `brew install mise`. Do not do it for them. | ||
| 2. Run `mise install` | ||
| 3. Export all the env vars as given by `mise env` |
There was a problem hiding this comment.
I specifically don't want to use eval because that trips most security checks
Clarified instructions for exporting environment variables.
| Before using `aws`, `pnpm` or `node`: | ||
| 1. If `mise` is not installed, stop and ask the user to install it with `brew install mise`. Do not do it for them. | ||
| 2. Run `mise install` | ||
| 3. `export` all the env vars as given by `mise env` in the current shell for the next command invocations. Notably, this will override `PATH`. |
There was a problem hiding this comment.
There are 2 recommended ways:
eval "$(mise activate)"eval "$(mise activate --shims)"
--shims is much simpler:
export PATH="/Users/slavoie2/.local/share/mise/shims:$PATH"
However, both need eval, and harness really don't like that, routinely blocking the execution.
Adding ~/.local/share/mise/shims to PATH could work, but:
- It feels brittle to manipulate the PATH directly and assuming some things about the environments
- shims change the resolved path of tools, sometimes creating other problems with path-based allow/blocklists
$ ls -l ~/.local/share/mise/shims
total 0
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 10 13:57 aws -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 10 13:57 aws_completer -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 7 09:54 corepack -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 7 09:54 node -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 7 09:54 npm -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 7 09:54 npx -> /opt/homebrew/bin/mise
lrwxr-xr-x@ 1 slavoie2 staff 22 Aug 7 09:54 pnpm -> /opt/homebrew/bin/mise
I tested this solution in Kiro and it works well.
I encourage reviewers to test before merging.
Jira
https://coveord.atlassian.net/browse/KIT-6038
Motivation
Coding agents need a clear, repository-specific way to initialize the managed CLI toolchain. The previous guidance referenced nvm and corepack even though this repository uses mise.
Changes
mise.tomlas the source of truth for the CLI toolchain.mise installbefore using repository CLI tools.Validation
pnpm run lint:fixAGENTS.md.Checklist
docs(agents): <description>)