chore(atomic): remove legacy-template-system.css - #8149
Draft
y-lakhdar wants to merge 8 commits into
Draft
Conversation
Migrate the Insight, Recommendation, and result placeholder components to the sanitized template-system.css. The shared ItemLayoutController now applies layout classes to result/product section elements on every interface so sections style themselves, replacing the removed monolithic descendant-combinator stylesheet.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
@coveo/atomic
@coveo/atomic-hosted-page
@coveo/atomic-legacy
@coveo/atomic-react
@coveo/auth
@coveo/bueno
@coveo/create-atomic
@coveo/create-atomic-component
@coveo/create-atomic-component-project
@coveo/create-atomic-result-component
@coveo/create-atomic-rollup-plugin
@coveo/create-ui
@coveo/headless
@coveo/headless-react
@coveo/relay
@coveo/shopify
commit: |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 465 tests unchanged |
🦋 Changeset detectedLatest commit: da975e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
y-lakhdar
had a problem deploying
to
PR Artifacts
August 10, 2026 17:48 — with
GitHub Actions
Failure
…om:coveo/ui-kit into KIT-5571-remove-legacy-template-system-css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
legacy-template-system.css(KIT-5571) by migrating its last three consumers — Insight results, Recommendation results, and the result placeholder — onto the sanitizedtemplate-system.css, then deletes the legacy stylesheet and its now-orphaned imports.What it does
atomic-result-section-*element itself (sections style their own host), whereas the legacy stylesheet positioned sections with descendant-combinator selectors from.result-root. Search and Commerce already work this way because their layout-controllerelementPrefixmatches their section tags.atomic-result-section-*tags, whose names don't match their prefixes, so their sections were never classed.ItemLayoutControllernow always applies layout classes to shared item-section elements (regardless of prefix orclassesOnly); prefixed children keep their previous behavior. This is idempotent for Search/Commerce..with-sectionscontainer/hover/first-of-type rules to.result-rootso they no longer leak onto the newly-classed section elements.legacy-template-system.cssand its imports (with-sections,row-desktop,row-mobile,cell-desktop,cell-mobile).atomic-children.cssis intentionally kept — it is still used bysections/section-children.css.