Skip to content

chore(atomic): remove legacy-template-system.css - #8149

Draft
y-lakhdar wants to merge 8 commits into
mainfrom
KIT-5571-remove-legacy-template-system-css
Draft

chore(atomic): remove legacy-template-system.css#8149
y-lakhdar wants to merge 8 commits into
mainfrom
KIT-5571-remove-legacy-template-system-css

Conversation

@y-lakhdar

@y-lakhdar y-lakhdar commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes legacy-template-system.css (KIT-5571) by migrating its last three consumers — Insight results, Recommendation results, and the result placeholder — onto the sanitized template-system.css, then deletes the legacy stylesheet and its now-orphaned imports.

What it does

  • The sanitized template system lays sections out via layout classes on each atomic-result-section-* element itself (sections style their own host), whereas the legacy stylesheet positioned sections with descendant-combinator selectors from .result-root. Search and Commerce already work this way because their layout-controller elementPrefix matches their section tags.
  • Insight and Recommendation reuse the shared atomic-result-section-* tags, whose names don't match their prefixes, so their sections were never classed. ItemLayoutController now always applies layout classes to shared item-section elements (regardless of prefix or classesOnly); prefixed children keep their previous behavior. This is idempotent for Search/Commerce.
  • The result placeholder renders its sections directly (no layout controller), so it now applies the same layout classes to each section element.
  • Scoped the Insight .with-sections container/hover/first-of-type rules to .result-root so they no longer leak onto the newly-classed section elements.
  • Deletes legacy-template-system.css and its imports (with-sections, row-desktop, row-mobile, cell-desktop, cell-mobile). atomic-children.css is intentionally kept — it is still used by sections/section-children.css.

Migrate the Insight, Recommendation, and result placeholder components to the sanitized template-system.css. The shared ItemLayoutController now applies layout classes to result/product section elements on every interface so sections style themselves, replacing the removed monolithic descendant-combinator stylesheet.
@svcsnykcoveo

svcsnykcoveo commented Aug 3, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown
@coveo/atomic

npm i https://pkg.pr.new/@coveo/atomic@8149

@coveo/atomic-hosted-page

npm i https://pkg.pr.new/@coveo/atomic-hosted-page@8149

@coveo/atomic-legacy

npm i https://pkg.pr.new/@coveo/atomic-legacy@8149

@coveo/atomic-react

npm i https://pkg.pr.new/@coveo/atomic-react@8149

@coveo/auth

npm i https://pkg.pr.new/@coveo/auth@8149

@coveo/bueno

npm i https://pkg.pr.new/@coveo/bueno@8149

@coveo/create-atomic

npm i https://pkg.pr.new/@coveo/create-atomic@8149

@coveo/create-atomic-component

npm i https://pkg.pr.new/@coveo/create-atomic-component@8149

@coveo/create-atomic-component-project

npm i https://pkg.pr.new/@coveo/create-atomic-component-project@8149

@coveo/create-atomic-result-component

npm i https://pkg.pr.new/@coveo/create-atomic-result-component@8149

@coveo/create-atomic-rollup-plugin

npm i https://pkg.pr.new/@coveo/create-atomic-rollup-plugin@8149

@coveo/create-ui

npm i https://pkg.pr.new/@coveo/create-ui@8149

@coveo/headless

npm i https://pkg.pr.new/@coveo/headless@8149

@coveo/headless-react

npm i https://pkg.pr.new/@coveo/headless-react@8149

@coveo/relay

npm i https://pkg.pr.new/@coveo/relay@8149

@coveo/shopify

npm i https://pkg.pr.new/@coveo/shopify@8149

commit: da975e4

@chromatic-com

chromatic-com Bot commented Aug 3, 2026

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 465 tests unchanged
🟢 UI Review: 465 stories published -- no changes
Storybook icon Storybook Publish: 465 stories published

@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: da975e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@coveo/atomic Patch
@coveo/atomic-react Patch
@coveo/atomic-angular Patch
@coveo/ui-kit-sample-atomic-commerce-vite Patch
@coveo/ui-kit-sample-atomic-search-vite Patch
@coveo/ui-kit-sample-atomic-commerce-react Patch
@coveo/ui-kit-sample-atomic-search-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@y-lakhdar
y-lakhdar deployed to pr-workflows August 11, 2026 15:02 — with GitHub Actions Active
@y-lakhdar y-lakhdar changed the title chore(atomic): remove legacy-template-system.css j:KIT-5571 chore(atomic): remove legacy-template-system.css Aug 11, 2026
…om:coveo/ui-kit into KIT-5571-remove-legacy-template-system-css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants