15 fmp provider#16
Draft
jaapterwoerds wants to merge 5 commits into
Draft
Conversation
1baf982 to
07e4aa7
Compare
d2f9d45 to
bb67891
Compare
bb67891 to
df7cf6d
Compare
Contributor
Author
|
GIve me a moment to update this PR with changes from master. In addition I want to make changes so that the training data and validation data can make use of as much data as available from the provider (see also #21 ) |
f1c5518 to
e04df2c
Compare
Contributor
|
hey :) @jrdi @jaapterwoerds I thought about adding AlphaVantage support to opensignals. Thanks! |
Collaborator
|
hey, imo it would be better if we first do a PR refactoring of the code and move the required code to a common place, then we can start working on other changes adding more providers. |
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here a first version of an implementation of an data provider for https://financialmodelingprep.com/. I factored out most code so that implementing a data provider is basically implementing one function that interacts with the data provider's API.
Feedback is appreciated!
Closes #15