Skip to content

Stabilize Fisher covariance postprocessing - #228

Open
fujikix1102 wants to merge 2 commits into
cosmosis-developers:mainfrom
fujikix1102:audit/fisher-covariance-cholesky
Open

fujikix1102 wants to merge 2 commits into
cosmosis-developers:mainfrom
fujikix1102:audit/fisher-covariance-cholesky

Conversation

@fujikix1102

Copy link
Copy Markdown

Summary

  • convert Fisher matrices with Cholesky factorization and explicit SPD validation
  • use the stable covariance helper for 1D uncertainties and ellipse areas
  • compute Fisher figure of merit from slogdet
  • add tests for reference agreement and invalid matrices

Validation

  • pytest -q cosmosis/test/test_postprocessing_statistics.py --disable-warnings --maxfail=1 (3 passed)
  • Python compilation and git diff --check passed

@fujikix1102

Copy link
Copy Markdown
Author

Added follow-up commit ee26785: covariance standard deviations now reject non-finite/negative diagonals, ellipse areas reject non-positive/non-finite determinants, and Fisher FOM validates a positive parameter count. Added 3 regression tests; all pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant