Use stable logsumexp in grid plots - #223
Open
fujikix1102 wants to merge 2 commits into
Open
fujikix1102 wants to merge 2 commits into
fujikix1102 wants to merge 2 commits into
Conversation
Author
|
The Python 3.9 macOS/Ubuntu jobs terminate after the existing MultiNest/PolyChord/L-BFGS-B sampler output with exit code 1; the available excerpt contains no grid-plots traceback or failing test name. All 3.10+ jobs pass. Could a maintainer please rerun the two 3.9 jobs or expose the final pytest traceback? The dedicated grid-plot tests pass locally. |
Author
|
CI run 35924752621 identified the failure: the new empty-group regression test called logsumexp on an empty array, raising ValueError in Python 3.9. Commit c10ef96 now treats an empty marginalization group as mathematical log-sum-exp = -inf. The two grid plot tests pass locally; please rerun CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log(exp(like).sum())calculations with SciPy's stablelogsumexpValidation
pytest -q cosmosis/test/test_grid_plots.py --disable-warnings --maxfail=1(2 passed)git diff --checkpassed