Use Cholesky solves in PMC covariance evaluation - #222
Open
fujikix1102 wants to merge 1 commit into
Open
fujikix1102 wants to merge 1 commit into
fujikix1102 wants to merge 1 commit into
Conversation
Author
|
Follow-up validation: installed dynesty, zeus-mcmc, and nautilus-sampler in the test environment. Full |
Author
|
Performance/reproducibility check: with the same seed (20260924), dimension=24, 4,000 samples, and 8 log-density evaluations per timing run, the Cholesky implementation had median 0.00335 s versus 0.03759 s for the previous explicit-inverse implementation (11.2x speedup). Maximum absolute log-density difference was 1.42e-13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Anormalization attribute for compatibilityValidation
pytest -q cosmosis/test/test_samplers.py -k 'pmc or pmaxlike or maxlike' --disable-warnings --maxfail=1(17 passed)git diff --checkpassedThe complete sampler test file is environment-limited here because the optional
dynestydependency is not installed.