Add error callback to list() on DbQueryCollection in store.sql as sql might fail

[miklschmidt]

All the sql stores has error callbacks in their executeSql methods, but the list() method in store.sql doesn't use them. So when a query fails, you'll never know.

I ran into this issue while using the migration plugin, i accidentally created a table with the plural version of the entity's name, and didn't get any callbacks while using the list() function after doing Entity.all().

I added support for error callbacks in .list() on DbQueryCollection, to fix this issue.

[AndreaSpinelli]

Conflicting, for instance, with the convention of persistence.flush (callback should check second arg for error)

[AndreaSpinelli]

I support the issue, because .list(/) and .count() do fail! (see below for an example)

However, IMHO, a better solution would be just to use the same callback on line 711 of persistence.store.sql.js:

      }, callback );

by the way, se same applies to .count() and again a simple fix is changing line 844 to

      }, callback );

This is consistent with the general convention of persistence.js that callbacks should test their second argument; if it is not-null, it is a SQL error.

A simple index.html for testing:

<title>Test</title> <script type="text/javascript" src="persistence.store.sql.js"></script> <script type="text/javascript" src="persistence.store.websql.js"></script> <script type="text/javascript" src="persistence.js"></script> <script> persistence.store.websql.config(persistence, 'test_test', 'test', 10000); var schema_of_foo = { bar: "TEXT NOT NULL", baz: 'INTEGER' }; var foo = persistence.define( 'foo', schema_of_foo ); persistence.schemaSync(function(tx) { foo.all().filter("foobaz","=","x").list(function(result, error) { if( error ){ alert("OK! Error detected in list: " + error.message ); } else { alert("KO! error not detected..."); } }); foo.all().filter("foobaz","=","x").count(function(result, error) { if( error ){ alert("OK! Error detected in count: " + error.message ); } else { alert("KO! error not detected..."); } }); }); </script>