-
Notifications
You must be signed in to change notification settings - Fork 293
providers/outscale: add Outscale support #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moh2a
wants to merge
1
commit into
coreos:main
Choose a base branch
from
moh2a:outscale-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright 2026 CoreOS, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // The outscale provider fetches a remote configuration from the Outscale | ||
| // user-data metadata service URL. | ||
|
|
||
| package outscale | ||
|
|
||
| import ( | ||
| "net/url" | ||
|
|
||
| "github.com/coreos/ignition/v2/config/v3_7_experimental/types" | ||
| "github.com/coreos/ignition/v2/internal/platform" | ||
| "github.com/coreos/ignition/v2/internal/providers/util" | ||
| "github.com/coreos/ignition/v2/internal/resource" | ||
|
|
||
| "github.com/coreos/vcontext/report" | ||
| ) | ||
|
|
||
| // userdataURL is the Outscale metadata service endpoint for user-data. | ||
| var ( | ||
| userdataURL = url.URL{ | ||
| Scheme: "http", | ||
| Host: "169.254.169.254", | ||
| Path: "/latest/user-data", | ||
| } | ||
| ) | ||
|
|
||
| // init registers the Outscale provider with the platform registry. | ||
| func init() { | ||
| platform.Register(platform.Provider{ | ||
| Name: "outscale", | ||
| Fetch: fetchConfig, | ||
| }) | ||
| } | ||
|
|
||
| // fetchConfig fetches the Ignition config from the Outscale metadata service. | ||
| func fetchConfig(f *resource.Fetcher) (types.Config, report.Report, error) { | ||
| data, err := f.FetchToBuffer(userdataURL, resource.FetchOptions{}) | ||
| if err != nil { | ||
| if err == resource.ErrNotFound { | ||
| return types.Config{}, report.Report{}, nil | ||
| } | ||
| return types.Config{}, report.Report{}, err | ||
| } | ||
|
|
||
| return util.ParseConfig(f.Logger, data) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Handle empty successful user-data responses as no configuration.
resource.ErrNotFoundhandling covers a missing endpoint response, but it does not cover an empty successful response.FetchToBufferaccepts HTTP 204 and can return zero-length data;util.ParseConfigthen returnserrors.ErrEmpty. An Outscale instance without populated user-data can therefore fail instead of continuing with an empty configuration. (raw.githubusercontent.com)Return an empty
types.Configwhenlen(data) == 0, while preserving non-resource.ErrNotFounderrors and parsing non-empty data.As per path instructions, “Platform providers must retry config fetches, allow empty config, and never guess the platform ID.”
Proposed fix
if err != nil { if err == resource.ErrNotFound { return types.Config{}, report.Report{}, nil } return types.Config{}, report.Report{}, err } + if len(data) == 0 { + return types.Config{}, report.Report{}, nil + } return util.ParseConfig(f.Logger, data)🤖 Prompt for AI Agents
Source: Path instructions