Repository navigation
refactor: use the existing shared helpers - #769
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-11777-reuse-shared-helpers
branch
from
October 29, 2026 16:45
2b3cef9 to
73cca96
Compare
TheGreatAxios
marked this pull request as ready for review
October 29, 2026 16:45
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
Contributor
There was a problem hiding this comment.
Replaces duplicated helpers across the monorepo with shared versions from @corbits/common (errorText, isRecord, optionalString, decodedSegment, counted), reuses githubAppLogin and mirrorCallId where they were copied, and consolidates the extension's settle into one module. The change is intended to be behaviour-preserving, and the description reports passing checks, lint, and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces copies of helpers that already exist with the shared version, with no change in behaviour, across four commits. The shared helpers
errorText,isRecord,optionalString,decodedSegmentandcountednow live in@corbits/common;githubAppLoginandmirrorCallIdare reused where they were copied; the extension has onesettle.errorTextreplaces the inlineinstanceof Errorternary everywhere it was written out, including the eval fixtures, the model test and the check pack.repo-read-toolandtests/modelnow depend on@corbits/common(workspace:*).countedmoved from the portal into@corbits/commonand replaces every other pluraliser (portal pages, the triage comment, the review-clean findings text).apps/web/src/lib/plural.tsis gone. The portal'striage-view.tscountedformats numbers differently and stays.decodedSegment; two hub tests build the mirror id withmirrorCallId.Verified with
bun run check,bun run lint(only existing warnings),bun run test:unitand the manager-routes and server Postgres tests, run three times.Closes CL-11777