Repository navigation
refactor: delete unused symbols - #766
Merged
Merged
Conversation
TheGreatAxios
marked this pull request as ready for review
October 29, 2026 15:50
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Removes several unused symbols (listFiles, templatesFor, DEFAULT_SCORE_LEVELS, CheckRef, applyRecommended, customRuleId) and their dependent imports and tests across the check pack contract and facts logic, with a README update. No findings were reported for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes symbols that nothing in the repository used besides their own definitions and tests:
listFilesandtemplatesForfrom the facts logic, andDEFAULT_SCORE_LEVELS,CheckRef,applyRecommendedandcustomRuleIdfrom the check pack contract. Imports that only those functions used are removed too.The two check pack tests that covered
applyRecommendedandcustomRuleIdare removed. The check pack test that mixedcustomRuleIdwithreadCheckPackvalidation keeps its validation checks and uses literal ids instead.Verified with
bun run check,bun run lint(no hits in the touched files), and the unit tests of packages/triage-contracts and packages/triage-workflows. A repository-wide search finds no remaining references to the removed names.Closes CL-11776