Repository navigation
fix(web): give the mobile portal room to breathe - #756
Closed
TheGreatAxios wants to merge 3 commits into
Closed
TheGreatAxios wants to merge 3 commits into
TheGreatAxios wants to merge 3 commits into
Conversation
Contributor
Author
|
Closing: the portal UX is getting a full mockup-first redesign, which will replace this change. Status and screenshots are kept on the Linear issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Held for owner screenshot review. Do not mark ready or merge until the owner has looked at the before and after screenshots.
On a phone the Triage list, Repositories and the pull request pane now have room. The change is CSS in the existing phone media queries, plus one markup change: a repository name now marks its owner, so a phone can set the owner on its own line. Behaviour is unchanged, and desktop renders the same.
Verified with the portal running against a fixture hub with long repository names, long titles, four held actions and three code review findings: screenshots at 390×844 and 360×780 with touch emulated, and at 1280×800, before and after, plus the Triage list at 320×640 and with filters applied. The list's slices fit at 320 px. The desktop screenshots differ only in relative times.
bun run check,bun run lint, and the web unit and DOM tests pass.No docs changed: the User Manual describes no layout this changes, and DESIGN.md already asks for 44 px touch buttons.
Closes CL-11724