Skip to content

refactor(code-review): tidy the unread note, log and types - #755

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11755-tidy-the-code-reviews-unread-note
Oct 29, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11755-tidy-the-code-reviews-unread-note

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

The portal's incomplete-review note now shows the unread files on their own line under the note, built from a helper that returns null when there is nothing to name instead of an empty string. The portal types the unread lines with the shared contract type, and the text-joining helper moves from the held-action logic to the shared view text helpers.

The hub logs an incomplete review's unread paths as the review already capped them, without a second cap of 20. The code review route no longer answers a total count of open findings, which nothing read; each finding keeps its own open flag. The route description and docs/ARCHITECTURE.md say so.

The code review runs test now checks that asking for one head's reviews reads nothing from the host, instead of a fixed total of host reads.

Verified with bun run check, bun run lint, the web unit and DOM tests, and the hub Postgres tests for code review runs, manager routes, GitHub read access and the Bitbucket send. Screenshots of the note with 37 unread files, at desktop width and at 390px, show the list on its own line with long paths wrapping. The user manual says the unread files follow the note, which still holds, so it did not change.

Closes CL-11755

@linear-code

linear-code Bot commented Oct 29, 2026

Copy link
Copy Markdown

CL-11755

@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 29, 2026 08:19
@corbits-triage

corbits-triage Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Notes:

  • Risk: medium (5 recently fixed files)

@corbits-triage corbits-triage Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactors the incomplete-review note so unread files render on their own line, types unread lines with the shared contract, moves a text-joining helper to shared view text helpers, drops a second 20-item cap in the hub log, and removes the unused open-findings total from the code review route. The change describes itself as a tidy-up with no behavior change beyond the removed total and the log cap, and no defects were raised in this review.

@TheGreatAxios
TheGreatAxios added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 3f0f112 Oct 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant