Repository navigation
refactor(code-review): tidy the unread note, log and types - #755
Merged
Merged
Conversation
TheGreatAxios
marked this pull request as ready for review
October 29, 2026 08:19
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
Contributor
There was a problem hiding this comment.
Refactors the incomplete-review note so unread files render on their own line, types unread lines with the shared contract, moves a text-joining helper to shared view text helpers, drops a second 20-item cap in the hub log, and removes the unused open-findings total from the code review route. The change describes itself as a tidy-up with no behavior change beyond the removed total and the log cap, and no defects were raised in this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portal's incomplete-review note now shows the unread files on their own line under the note, built from a helper that returns null when there is nothing to name instead of an empty string. The portal types the unread lines with the shared contract type, and the text-joining helper moves from the held-action logic to the shared view text helpers.
The hub logs an incomplete review's unread paths as the review already capped them, without a second cap of 20. The code review route no longer answers a total count of open findings, which nothing read; each finding keeps its own
openflag. The route description and docs/ARCHITECTURE.md say so.The code review runs test now checks that asking for one head's reviews reads nothing from the host, instead of a fixed total of host reads.
Verified with
bun run check,bun run lint, the web unit and DOM tests, and the hub Postgres tests for code review runs, manager routes, GitHub read access and the Bitbucket send. Screenshots of the note with 37 unread files, at desktop width and at 390px, show the list on its own line with long paths wrapping. The user manual says the unread files follow the note, which still holds, so it did not change.Closes CL-11755