Repository navigation
Set Node 24 floor for corbits-memory - #42
Merged
Merged
Conversation
Contributor
Author
ReviewVerdict: approve with nits. MERGEABLE. CI: Does what CL-8539 asks: Should-fix (hygiene this diff introduced): the Node job has no lockfile ( Conflicts with #37 on README Requirements. Merge this first if both stay open, then rewrite #37’s Requirements so the Node floor survives. |
Add engines.node >=24 alongside the existing Bun floor, cover Node 24 in CI, and state the floor in README. CL-8539.
Do not clobber the sidecar product line. engines.node >=24 is for Node-side tooling; native Node does not load extensionless TypeScript source.
TheGreatAxios
force-pushed
the
cl-8539-set-node-24-floor-for-corbitsmemory
branch
from
September 21, 2026 01:26
c3b843c to
dd4091b
Compare
TheGreatAxios
deleted the
cl-8539-set-node-24-floor-for-corbitsmemory
branch
September 21, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets engines.node to >=24 (existing Bun >=1.2.0 floor untouched), adds a Node 24 CI job (setup-node matrix, tsc --noEmit, npm pack --dry-run), and states the Node 24 floor in README requirements. Verified: bun run typecheck, bun run test (481 pass), npm pack --dry-run. CL-8539.