Trim the test suite, close coverage gaps, and parallelize CI - #834
Open
TheGreatAxios wants to merge 14 commits into
Open
Trim the test suite, close coverage gaps, and parallelize CI#834TheGreatAxios wants to merge 14 commits into
TheGreatAxios wants to merge 14 commits into
Conversation
The suite pinned packaged skill prose, palette hexes, ANSI-256 indexes, display-name branding, and animation frames, and carried duplicated copies of faremeter, stream-consumer, and inference-abort coverage. Those broke on every wording or palette edit without guarding behavior, and two eval test files were never run at all. Manifest, inventory, frontmatter-flag, and behavioral invariants stay.
sh -c, xargs, transparent env prefixes, and quoted program/flag spellings previously had no coverage for the git-global-config rule; only the plain forms were pinned. Assert they all still ask, and that scoped read-only git config forms stay unflagged.
Existing torn-tail tests only tear a tail segment behind a clean turns.jsonl. A session small enough to never roll over tears the base the isogit store parses first, which takes the resilient recovery path instead. Pin that the base-only tear recovers committed turns, extra segments survive it, and the next write heals the file.
Pin that disposeExecRuntime cancels all live workers with the close reason before agent teardown starts, and that a rejected agent close neither blocks toolset disposal nor rejects the teardown.
Cover the enqueue-during-await race: a rotation queued while a delivery is still awaiting its send must wait for the delivery to settle, and a failed delivery must not block the rotation behind it.
The connect mock served one static tool payload, so reconnect tests could not observe a server whose tools changed between generations. Parameterize the payload and pin that reconnect mounts exactly the drifted set: renamed schema on the same tool, a new tool, a single definition per name, the stale client closed, and the drift announced through onToolsChanged.
The mount-gate probes await a full runSubAgent cycle whose inference send to an unreachable host classifies as retryable, so each test slept through the client's full backoff schedule (three attempts, 500ms plus 1000ms fixed) before asserting mount counts. Under suite load that crossed the 5s per-test timeout. Point the send at a local server answering 401, which classifies credential_failure and never retries, and give the four full-runtime probes a 15s timeout to absorb construction-time load spikes.
Tests that pin an asset's literal wording or an exact palette value fail on copy and design edits while catching no behavior regression, and an audit found most low-value tests shared that shape. A local eslint rule now rejects the known shapes in test files; it is a heuristic shape match, calibrated to stay silent on behavior-string assertions like command parsing, approval display, and permission tokenization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Fixes CL-7514
Fixes CL-7515
Fixes CL-7513
Fixes CL-7516