Split the TUI god-files and gate repaints on change - #826
Merged
Conversation
Policing gates constrain how future changes look rather than whether they work. The split stays documented; the suite verifies behavior only.
The split deleted src/tui/runner.ts while main removed the Codex instructions refresh from it, so port that removal into the split modules instead: drop the refresh block and the ready delivery option from runner/session.ts and runner/state.ts, matching main's deletion of src/auth/codex/instructions.ts.
Permission approval choices embedded each scope's hint inside the label, and the fixed-height choice rows truncated those labels with an ellipsis the operator could not expand. Labels are now the bare action name and the scope hints paint as body messages above the choice list, where the expand key reaches them. The unused choice wrapping/marker helpers go with the behavior they served, the provider setup's list height budget moves off the surface module to break the choices-surface-oauth import cycle, and the overlay list regains the viewport coverage lost in the wrapper move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run checkpasses with 6,288 tests and 0 failures, verified in two independent full-suite runsbun run tui:smokepassesFixes CL-6791